Add support to mine cargo Package-URLs#679
Conversation
ziadhany
force-pushed
the
min-cargo
branch
2 times, most recently
from
5cdc47b to
ae60ff2
Compare
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Thanks @ziadhany, looks good as a start. Please see my comments for your consideration
|
@ziadhany what's left todo here? |
|
@pombredanne I just need to use the common function. But I already tested running the workflow in this repo: https://github.com/ziadhany/cargo-test/. I will update it today. |
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Thanks @ziadhany, looking good.
See my comments for your consideration. We can also start testing this in the aboutcode-data CI now
|
|
||
| DATA_DIR = Path(__file__).parent.parent / "test_data" / "cargo" | ||
|
|
||
|
|
There was a problem hiding this comment.
A bit more tests for cargo mining would be nice, we can create a small repo with some commits to test, this is okay
There was a problem hiding this comment.
@AyanSinhaMahapatra I added multiple test cases for Cargo, and also tested the entire workflow using these three repositories:
There was a problem hiding this comment.
Thanks @ziadhany, looks good. Could you use these repositories instead:
- https://github.com/aboutcode-data/minecode-pipelines-config
- https://github.com/aboutcode-data/minecode-data-cargo-test
And run this using the CI action added at aboutcode-data/minecode-pipelines-config#1?
The issue can be closed with this ^
Merging the PR as everything looks good otherwise.
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Refactor code to be compatible with the new pipeline. Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Add logging and fix bug in process_cargo_packages Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Fix bug in process_cargo_packages. Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
4 participants
Uh oh!
There was an error while loading. Please reload this page.